chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h - Issue 888713002: DataReductionProxyStatisticsPrefs should support WeakPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

Issue 888713002: DataReductionProxyStatisticsPrefs should support WeakPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Webview fix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc ('k') | chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

index 57fbf651ca856c755741eba0a145df0426c780db..49a5c054e198f9f1b497a8b70f1b89b9507362e3 100644

--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

@@ -43,7 +43,8 @@ class DataReductionProxyChromeSettings

~DataReductionProxyChromeSettings() override;

// Initialize the settings object with the given configurator, prefs services,

- // and request context.

+ // and request context. Settings takes ownership of statistics prefs from

+ // |io_data|.

void InitDataReductionProxySettings(

data_reduction_proxy::DataReductionProxyIOData* io_data,

PrefService* profile_prefs,