DataReductionProxyStatisticsPrefs should support WeakPtr

components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
index 911668705fed33cf74bf7068c2e001c537e635ec..f35cb936fff0132be7f784268e4514ef3f799161 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
@@ -83,14 +83,25 @@ class DataReductionProxySettings
   // |DataReductionProxySettings| instance.
   void InitDataReductionProxySettings(
       PrefService* prefs,
+      scoped_ptr<DataReductionProxyStatisticsPrefs> statistics_prefs,
       net::URLRequestContextGetter* url_request_context_getter,
       net::NetLog* net_log,
       DataReductionProxyEventStore* event_store);
 
-  // Sets the |statistics_prefs_| to be used for data reduction proxy pref reads
-  // and writes.
+  // Constructs statistics prefs. This is not necessary if a valid statistics
+  // prefs is passed into the constructor.

[bengr, 2015/02/04 23:39:11]

Is it safe to call it if a valid statistics prefs was passed into the
constructor? I think probably not, so we should probably enforce that.

[megjablon, 2015/02/06 23:40:42]

Done.

+  void EnableCompressionStatisticsLogging(
+      PrefService* prefs,
+      scoped_refptr<base::SequencedTaskRunner> ui_task_runner,
+      const base::TimeDelta& commit_delay);
+
+  // Used for testing.
   void SetDataReductionProxyStatisticsPrefs(

[bengr, 2015/02/04 23:39:11]

Does this need to be public? Also, move this down after all the non-test
methods.

[megjablon, 2015/02/06 23:40:42]

Yes, it needs to be public since DRPSettingsTestBase isn't a subclass.

-      DataReductionProxyStatisticsPrefs* statistics_prefs);
+      scoped_ptr<DataReductionProxyStatisticsPrefs> statistics_prefs);
+
+  DataReductionProxyStatisticsPrefs* statistics_prefs() const {
+    return statistics_prefs_.get();
+  }
 
   // Sets the |on_data_reduction_proxy_enabled_| callback and runs to register
   // the DataReductionProxyEnabled synthetic field trial.
@@ -283,7 +294,7 @@ class DataReductionProxySettings
   BooleanPrefMember data_reduction_proxy_alternative_enabled_;
 
   PrefService* prefs_;
-  DataReductionProxyStatisticsPrefs* statistics_prefs_;
+  scoped_ptr<DataReductionProxyStatisticsPrefs> statistics_prefs_;
 
   net::URLRequestContextGetter* url_request_context_getter_;