Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: android_webview/browser/aw_browser_context.cc

Issue 888713002: DataReductionProxyStatisticsPrefs should support WeakPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_browser_context.cc
diff --git a/android_webview/browser/aw_browser_context.cc b/android_webview/browser/aw_browser_context.cc
index f20bd9ce62cf1b5da6b28a95097263d501323401..be601f28edf043cc0895b81c88fd276c0338996f 100644
--- a/android_webview/browser/aw_browser_context.cc
+++ b/android_webview/browser/aw_browser_context.cc
@@ -125,8 +125,6 @@ void AwBrowserContext::SetDataReductionProxyEnabled(bool enabled) {
// context->data_reduction_proxy_io_data() is valid.
DCHECK(context->GetDataReductionProxyIOData());
context->CreateDataReductionProxyStatisticsIfNecessary();
- proxy_settings->SetDataReductionProxyStatisticsPrefs(
- context->GetDataReductionProxyIOData()->statistics_prefs());
proxy_settings->SetDataReductionProxyEnabled(data_reduction_proxy_enabled_);
}
@@ -167,8 +165,6 @@ void AwBrowserContext::PreMainMessageLoopRun() {
data_reduction_proxy_io_data_.reset(
new data_reduction_proxy::DataReductionProxyIOData(
data_reduction_proxy::Client::WEBVIEW_ANDROID,
- scoped_ptr<
- data_reduction_proxy::DataReductionProxyStatisticsPrefs>(),
data_reduction_proxy_settings_.get(),
url_request_context_getter_->GetNetLog(),
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO),
@@ -279,6 +275,7 @@ void AwBrowserContext::CreateUserPrefServiceIfNecessary() {
if (data_reduction_proxy_settings_) {
data_reduction_proxy_settings_->InitDataReductionProxySettings(
user_pref_service_.get(),
+ scoped_ptr<data_reduction_proxy::DataReductionProxyStatisticsPrefs>(),
GetRequestContext(),
GetAwURLRequestContext()->GetNetLog(),
data_reduction_proxy_io_data_->event_store());
@@ -375,13 +372,17 @@ void AwBrowserContext::RebuildTable(
void AwBrowserContext::CreateDataReductionProxyStatisticsIfNecessary() {
DCHECK(user_pref_service_.get());
- DCHECK(GetDataReductionProxyIOData());
- if (GetDataReductionProxyIOData()->statistics_prefs())
+ DCHECK(GetDataReductionProxySettings());
+ if (GetDataReductionProxySettings()->statistics_prefs())
return;
// We don't care about commit_delay for now. It is just a dummy value.
base::TimeDelta commit_delay = base::TimeDelta::FromMinutes(60);
- GetDataReductionProxyIOData()->EnableCompressionStatisticsLogging(
- user_pref_service_.get(), commit_delay);
+ GetDataReductionProxySettings()->EnableCompressionStatisticsLogging(
+ user_pref_service_.get(),
+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI),
+ commit_delay);
+ GetDataReductionProxyIOData()->SetDataReductionProxyStatisticsPrefs(
+ GetDataReductionProxySettings()->statistics_prefs()->GetWeakPtr());
}
} // namespace android_webview

Powered by Google App Engine
This is Rietveld 408576698