components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc - Issue 888713002: DataReductionProxyStatisticsPrefs should support WeakPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc

Issue 888713002: DataReductionProxyStatisticsPrefs should support WeakPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DRPSettings owns DRPStatisticsPrefs Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc

index 6db23912782f74c9f910a40fd752e353c625c088..4ae17fa37aeb17448063b0ee86b432761c8aa7bb 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc

@@ -150,8 +150,8 @@ void DataReductionProxySettings::InitDataReductionProxySettings(

}

void DataReductionProxySettings::SetDataReductionProxyStatisticsPrefs(

- DataReductionProxyStatisticsPrefs* statistics_prefs) {

- statistics_prefs_ = statistics_prefs;

+ scoped_ptr<DataReductionProxyStatisticsPrefs> statistics_prefs) {

+ statistics_prefs_ = statistics_prefs.Pass();

}

void DataReductionProxySettings::SetOnDataReductionEnabledCallback(