components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc - Issue 888713002: DataReductionProxyStatisticsPrefs should support WeakPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc

Issue 888713002: DataReductionProxyStatisticsPrefs should support WeakPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DRPSettings owns DRPStatisticsPrefs Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc

index 8aa47d8a57fe16949648f0df278d5d4f7a298916..e9c81fa54d4d28b68b5f35dded296410f5c1fa92 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc

@@ -105,10 +105,12 @@ TEST_F(DataReductionProxyIODataTest, TestConstruction) {

DataReductionProxyStatisticsPrefs* statistics_prefs =

new DataReductionProxyStatisticsPrefs(

prefs(), message_loop_proxy(), base::TimeDelta());

+ settings()->SetDataReductionProxyStatisticsPrefs(

+ make_scoped_ptr(statistics_prefs));

scoped_ptr<DataReductionProxyIOData> io_data(

new DataReductionProxyIOData(

- Client::UNKNOWN, make_scoped_ptr(statistics_prefs), settings(),

- net_log(), message_loop_proxy(), message_loop_proxy()));

+ Client::UNKNOWN, settings(), net_log(),

+ message_loop_proxy(), message_loop_proxy()));

// Check that io_data creates an interceptor. Such an interceptor is

// thoroughly tested by DataReductionProxyInterceptoTest.