components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc - Issue 888713002: DataReductionProxyStatisticsPrefs should support WeakPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

Issue 888713002: DataReductionProxyStatisticsPrefs should support WeakPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DRPSettings owns DRPStatisticsPrefs Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc ('K') | « chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

index d577fcee44711dde66ddc373a228a812240435f1..59cc43d3cdc6e388011624ac64146374f7f2a65d 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

@@ -200,8 +200,6 @@ class DataReductionProxyInterceptorWithServerTest : public testing::Test {

io_data_.reset(

new DataReductionProxyIOData(

data_reduction_proxy::Client::UNKNOWN,

- scoped_ptr<

- data_reduction_proxy::DataReductionProxyStatisticsPrefs>(),

settings_.get(),

&net_log_,

loop_.message_loop_proxy(),