android_webview/browser/aw_browser_context.cc - Issue 888713002: DataReductionProxyStatisticsPrefs should support WeakPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_browser_context.cc

Issue 888713002: DataReductionProxyStatisticsPrefs should support WeakPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DRPSettings owns DRPStatisticsPrefs Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc » ('j') | chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/aw_browser_context.cc

diff --git a/android_webview/browser/aw_browser_context.cc b/android_webview/browser/aw_browser_context.cc

index 16d472455f142e0432d5de69c61f655a7b7e9797..8ff982f88c67858b2f083339e2b3158f523edcbb 100644

--- a/android_webview/browser/aw_browser_context.cc

+++ b/android_webview/browser/aw_browser_context.cc

@@ -125,8 +125,6 @@ void AwBrowserContext::SetDataReductionProxyEnabled(bool enabled) {

// context->data_reduction_proxy_io_data() is valid.

DCHECK(context->GetDataReductionProxyIOData());

context->CreateDataReductionProxyStatisticsIfNecessary();

- proxy_settings->SetDataReductionProxyStatisticsPrefs(

- context->GetDataReductionProxyIOData()->statistics_prefs());

proxy_settings->SetDataReductionProxyEnabled(data_reduction_proxy_enabled_);

}

@@ -165,8 +163,6 @@ void AwBrowserContext::PreMainMessageLoopRun() {

data_reduction_proxy_io_data_.reset(

new data_reduction_proxy::DataReductionProxyIOData(

data_reduction_proxy::Client::WEBVIEW_ANDROID,

- scoped_ptr<

- data_reduction_proxy::DataReductionProxyStatisticsPrefs>(),

data_reduction_proxy_settings_.get(),

url_request_context_getter_->GetNetLog(),

BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO),