DataReductionProxyStatisticsPrefs should support WeakPtr

chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
 
 #include "base/memory/scoped_ptr.h"
+#include "base/message_loop/message_loop_proxy.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/metrics/chrome_metrics_service_accessor.h"
 #include "chrome/browser/prefs/proxy_prefs.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/common/pref_names.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_auth_request_handler.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h"
@@ skipping 39 matching lines @@
 }
 
 DataReductionProxyChromeSettings::~DataReductionProxyChromeSettings() {
 }
 
 void DataReductionProxyChromeSettings::InitDataReductionProxySettings(
     data_reduction_proxy::DataReductionProxyIOData* io_data,
     PrefService* profile_prefs,
     PrefService* local_state_prefs,
     net::URLRequestContextGetter* request_context) {
+#if defined(OS_ANDROID) || defined(OS_IOS)
+  // On mobile we write data reduction proxy prefs directly to the pref service.
+  // On desktop we store data reduction proxy prefs in memory, writing to disk
+  // every 60 minutes and on termination. Shutdown hooks must be added for
+  // Android and iOS in order for non-zero delays to be supported.
+  // (http://crbug.com/408264)
+  base::TimeDelta commit_delay = base::TimeDelta();
+#else
+  base::TimeDelta commit_delay = base::TimeDelta::FromMinutes(60);
+#endif
+  scoped_ptr<data_reduction_proxy::DataReductionProxyStatisticsPrefs>
+  statistics_prefs(
+      new data_reduction_proxy::DataReductionProxyStatisticsPrefs(
+          profile_prefs, base::MessageLoopProxy::current(), commit_delay));
   SetProxyConfigurator(io_data->configurator());
   DataReductionProxySettings::InitDataReductionProxySettings(
       profile_prefs,
+      statistics_prefs.Pass(),
       request_context,
       io_data->net_log(),
       io_data->event_store());
   DataReductionProxySettings::SetOnDataReductionEnabledCallback(
       base::Bind(&DataReductionProxyChromeSettings::RegisterSyntheticFieldTrial,
                  base::Unretained(this)));
   SetDataReductionProxyAlternativeEnabled(
       DataReductionProxyParams::IsIncludedInAlternativeFieldTrial());
   // TODO(bengr): Remove after M46. See http://crbug.com/445599.
   MigrateDataReductionProxyOffProxyPrefs(profile_prefs);
+  io_data->SetDataReductionProxyStatisticsPrefs(
+      DataReductionProxySettings::statistics_prefs()->GetWeakPtr());

[bengr, 2015/02/04 23:39:10]

Add a comment to the declaration of InitDRPSettings that mentioned that io_data
is given a weak pointer to the statistics prefs that is owned by settings.

[megjablon, 2015/02/06 23:40:41]

Done.

 }
 
 void DataReductionProxyChromeSettings::RegisterSyntheticFieldTrial(
     bool data_reduction_proxy_enabled) {
   ChromeMetricsServiceAccessor::RegisterSyntheticFieldTrial(
       "DataReductionProxyEnabled",
       data_reduction_proxy_enabled ? "true" : "false");
 }
 
 // static
@@ skipping 15 matching lines @@
 #elif defined(OS_OPENBSD)
   return Client::CHROME_OPENBSD;
 #elif defined(OS_SOLARIS)
   return Client::CHROME_SOLARIS;
 #elif defined(OS_QNX)
   return Client::CHROME_QNX;
 #else
   return Client::UNKNOWN;
 #endif
 }