Issue 888703002: SkStream::read() only returns 0 at end.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 888703002: SkStream::read() only returns 0 at end. (Closed)

Created:
5 years, 10 months ago by scroggo

Modified:
5 years, 10 months ago

Reviewers:
djsollen, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

SkStream::read() only returns 0 at end. All implementations behave this way, so respect it. BUG=skia:2936 Committed: https://skia.googlesource.com/skia/+/65df6edf63c6b97ea81fb647c4ebd85729a750a2

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	src/images/SkImageDecoder_libwebp.cpp	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 8 (3 generated)

scroggo

On 2015/01/29 19:16:10, reed1 wrote: > Is this well documented as well? > lgtm Yes: ...

5 years, 10 months ago (2015-01-29 19:18:12 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888703002/1

5 years, 10 months ago (2015-01-29 19:18:49 UTC) #7

commit-bot: I haz the power

5 years, 10 months ago (2015-01-29 19:58:50 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/65df6edf63c6b97ea81fb647c4ebd85729a750a2