Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 888693004: Make RenderWidgetHostViewAuraTest.Resize robust to different IPC orderings (Closed)

Created:
5 years, 10 months ago by jbauman
Modified:
5 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make RenderWidgetHostViewAuraTest.Resize robust to different IPC orderings The precise order (or number) of some of these messages doesn't matter, so just handle them in a loop. Committed: https://crrev.com/da05552ea98db8423bf846e8b83097feda342808 Cr-Commit-Position: refs/heads/master@{#314024}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -24 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 1 chunk +31 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbauman
5 years, 10 months ago (2015-01-30 01:30:36 UTC) #2
piman
lgtm https://codereview.chromium.org/888693004/diff/1/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc (right): https://codereview.chromium.org/888693004/diff/1/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc#newcode1561 content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:1561: EXPECT_TRUE(false); nit: ADD_FAILURE() You can even add a ...
5 years, 10 months ago (2015-01-30 03:57:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888693004/20001
5 years, 10 months ago (2015-01-30 22:46:34 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 23:22:59 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 23:24:59 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da05552ea98db8423bf846e8b83097feda342808
Cr-Commit-Position: refs/heads/master@{#314024}

Powered by Google App Engine
This is Rietveld 408576698