Correctly handle out of storage space and "actively importing" states in controller.

Correctly handle out of storage space and "actively importing" states in controller.
Changes in task state trigger import controller updates (triggering scanning and UI updates).
Update test to work with new async update model.

Also: Fix media importer code to pass logical destination when marking a file imported.

+satorux for chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
BUG=420680
TEST=browser_test: FileManagerJsTest.*

Committed: https://crrev.com/c207bdf2512198ba73c6e9f0bec6d25ffd7faf40
Cr-Commit-Position: refs/heads/master@{#313869}

[Steve McKay, 2015-01-29 20:40:44]

Add test coverage of triggering update when import is finished or cancelled.

[Steve McKay, 2015-01-29 21:13:36]

smckay@chromium.org changed reviewers:
+ fukino@chromium.org, kenobi@chromium.org

[Steve McKay, 2015-01-29 21:25:42]

Fix import handler to pass logical import destination when marking for import.

[Ben Kwa, 2015-01-29 22:39:09]

lgtm

[Steve McKay, 2015-01-29 22:43:37]

Thanks. And I made all the changes we discussed offline.

[Steve McKay, 2015-01-29 23:32:15]

smckay@chromium.org changed reviewers:
+ hirono@chromium.org

[Steve McKay, 2015-01-29 23:32:15]

I'm thinking Fukino-san was working late...adding Hirono-san. Who ever reviews
first...I hope we can get an LGTM in the first round. Ben's has already
reviewed.

[hirono, 2015-01-30 01:24:04]

lgtm with comments.

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/media_import_handler_unittest.js
(right):

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/media_import_handler_unittest.js:170:
scanResult,
Please fix indent.

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/import_controller.js (right):

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/import_controller.js:67: * @private
{importer.MediaImportHandler.ImportTask}
nit: The comment says it is list. Isn't it Array?

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/import_controller.js:177: return
importer.ImportController.createUpdate_(
We should check the size of selected files also.

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/import_controller.js:178:
importer.ResponseId.EXECUTABLE, entries.length);
Is this entries.length is correct?
I mean some of the entries can have been already imported.

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/import_controller.js:213: * @param
{number=} opt_value
nit: Please add comment about what is the opt_value.

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/import_controller.js:287: * @return
{!Promise.<boolean>} true if the files in scan will fit
nit: true if ... -> True if ...

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/import_controller.js:486: //
TODO(smckay): Verify if this should be for Downloads or Drive.
It should not be Drive
Because it returns available space of cloud storage for Google Drive.

[Steve McKay, 2015-01-30 03:37:03]

Respond to review comments.

[Steve McKay, 2015-01-30 03:37:10]

The CQ bit was checked by smckay@chromium.org

[commit-bot: I haz the power, 2015-01-30 03:37:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/888693002/120001

[Steve McKay, 2015-01-30 03:37:43]

Dones. I'll send a followup tomorrow for size calc improvements.

Thank you Hirono-san.

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/media_import_handler_unittest.js
(right):

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/media_import_handler_unittest.js:170:
scanResult,
On 2015/01/30 01:24:04, hirono wrote:
> Please fix indent.

Done.

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/import_controller.js (right):

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/import_controller.js:67: * @private
{importer.MediaImportHandler.ImportTask}
On 2015/01/30 01:24:04, hirono wrote:
> nit: The comment says it is list. Isn't it Array?

Hmmm. I could swear I already pushed a fix for that.  Pushed!

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/import_controller.js:177: return
importer.ImportController.createUpdate_(
On 2015/01/30 01:24:04, hirono wrote:
> We should check the size of selected files also.

I'll add that to the backlog (and send you a change for that tomorrow). I also
forgot to add test coverage for the new size-checky code. Will add that
tooooooo.

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/import_controller.js:178:
importer.ResponseId.EXECUTABLE, entries.length);
On 2015/01/30 01:24:04, hirono wrote:
> Is this entries.length is correct?
> I mean some of the entries can have been already imported.

Good point. https://code.google.com/p/chromium/issues/detail?id=453703

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/import_controller.js:213: * @param
{number=} opt_value
On 2015/01/30 01:24:04, hirono wrote:
> nit: Please add comment about what is the opt_value.

Done. But this is hacky so not lovely or satisfying.

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/import_controller.js:287: * @return
{!Promise.<boolean>} true if the files in scan will fit
On 2015/01/30 01:24:04, hirono wrote:
> nit: true if ... -> True if ...

Done.

https://codereview.chromium.org/888693002/diff/100001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/import_controller.js:486: //
TODO(smckay): Verify if this should be for Downloads or Drive.
On 2015/01/30 01:24:04, hirono wrote:
> It should not be Drive
> Because it returns available space of cloud storage for Google Drive.

Perfect. THanks for answering that (and in the process answering another
question I have).

Converted the comment into a note for my self.

[Steve McKay, 2015-01-30 03:37:51]

smckay@chromium.org changed reviewers:
- fukino@chromium.org

[commit-bot: I haz the power, 2015-01-30 03:42:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-30 03:42:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Steve McKay, 2015-01-30 03:48:01]

smckay@chromium.org changed reviewers:
+ satorux@chromium.org

[satorux1, 2015-01-30 04:37:47]

chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc lgtm

[satorux1, 2015-01-30 04:37:53]

The CQ bit was checked by satorux@chromium.org

[commit-bot: I haz the power, 2015-01-30 04:38:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/888693002/120001

[satorux1, 2015-01-30 04:39:02]

Please add hirono@ to chrome/browser/chromeos/extensions/file_manager/OWNERS

[commit-bot: I haz the power, 2015-01-30 04:41:30]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-01-30 04:42:47]

Patchset 7 (id:??) landed as
https://crrev.com/c207bdf2512198ba73c6e9f0bec6d25ffd7faf40
Cr-Commit-Position: refs/heads/master@{#313869}

[Steve McKay, 2015-01-30 17:24:06]

On 2015/01/30 04:42:47, I haz the power (commit-bot) wrote:
> Patchset 7 (id:??) landed as
> https://crrev.com/c207bdf2512198ba73c6e9f0bec6d25ffd7faf40
> Cr-Commit-Position: refs/heads/master@{#313869}

Looks like I choked on this...and didn't upload patchset 8 prior to submitting.

Sorry about this. I'll get a followup CL out today with those changes and the
followup changes re: individual file selection and size calculations.