Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 888683002: Only auto-roll blink for the moment (Closed)

Created:
5 years, 10 months ago by vsm
Modified:
5 years, 10 months ago
Reviewers:
terry, rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Only auto-roll blink for the moment It'll take some time - hopefully not too long - to add git support for chrome src. We'll need to manually push chrome changes until then, but those are fewer, so I'll start with this. R=rmacnak@google.com Committed: 43433

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix for old bleeding edge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M update_deps.py View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
vsm
5 years, 10 months ago (2015-01-29 18:59:20 UTC) #2
rmacnak
lgtm for int, comments for edge https://codereview.chromium.org/888683002/diff/1/update_deps.py File update_deps.py (right): https://codereview.chromium.org/888683002/diff/1/update_deps.py#newcode43 update_deps.py:43: BRANCH_CURRENT="dart/dartium" current is ...
5 years, 10 months ago (2015-01-29 19:34:38 UTC) #3
vsm
https://codereview.chromium.org/888683002/diff/1/update_deps.py File update_deps.py (right): https://codereview.chromium.org/888683002/diff/1/update_deps.py#newcode43 update_deps.py:43: BRANCH_CURRENT="dart/dartium" On 2015/01/29 19:34:38, rmacnak wrote: > current is ...
5 years, 10 months ago (2015-01-29 20:11:36 UTC) #4
rmacnak
On 2015/01/29 20:11:36, vsm wrote: > https://codereview.chromium.org/888683002/diff/1/update_deps.py > File update_deps.py (right): > > https://codereview.chromium.org/888683002/diff/1/update_deps.py#newcode43 > ...
5 years, 10 months ago (2015-01-29 20:28:37 UTC) #5
vsm
On 2015/01/29 20:28:37, rmacnak wrote: > On 2015/01/29 20:11:36, vsm wrote: > > https://codereview.chromium.org/888683002/diff/1/update_deps.py > ...
5 years, 10 months ago (2015-01-29 20:44:44 UTC) #6
vsm
Committed patchset #2 (id:20001) manually as 43433 (presubmit successful).
5 years, 10 months ago (2015-02-03 21:55:28 UTC) #7
vsm
5 years, 10 months ago (2015-02-03 21:55:54 UTC) #8
Message was sent while issue was closed.
On 2015/01/29 20:44:44, vsm wrote:
> On 2015/01/29 20:28:37, rmacnak wrote:
> > On 2015/01/29 20:11:36, vsm wrote:
> > > https://codereview.chromium.org/888683002/diff/1/update_deps.py
> > > File update_deps.py (right):
> > > 
> > > https://codereview.chromium.org/888683002/diff/1/update_deps.py#newcode43
> > > update_deps.py:43: BRANCH_CURRENT="dart/dartium"
> > > On 2015/01/29 19:34:38, rmacnak wrote:
> > > > current is 2125
> > > 
> > > When do you want to push to bleeding_edge?  I was assuming soon.  :-)
> > 
> > Once we get the integration bots green. You can disregard that comment; it's
> > easy enough to do a one-shot update if needed.
> 
> The script running locally as is.  I'll land once we push to be.

I fixed for the old bleeding edge.  Will update after the roll.

Powered by Google App Engine
This is Rietveld 408576698