Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 888663003: cc: Fix flakiness in LayerTreeHostCopyRequestTestMultipleDrawsHiddenCopyRequest (Closed)

Created:
5 years, 10 months ago by danakj
Modified:
5 years, 10 months ago
Reviewers:
weiliangc, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO), piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix flakiness in LayerTreeHostCopyRequestTestMultipleDrawsHiddenCopyRequest This test was expecting the main thread copy request to happen before a new draw happens on the compositor thread which is racey. Instead do this comparison on the main thread by posting and trying to end the test after the draw happens but checking for the copy request result there on the main thread instead of on the impl thread before posting. R=vmpstr, weiliangc BUG=439649 Committed: https://crrev.com/c67de28bb2624a02fb1937b0f9c9b8ee160370c9 Cr-Commit-Position: refs/heads/master@{#313797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M cc/test/layer_tree_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_copyrequest.cc View 6 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
danakj
5 years, 10 months ago (2015-01-29 20:53:14 UTC) #1
vmpstr
lgtm
5 years, 10 months ago (2015-01-29 21:18:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888663003/1
5 years, 10 months ago (2015-01-29 21:21:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 21:39:26 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 21:40:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c67de28bb2624a02fb1937b0f9c9b8ee160370c9
Cr-Commit-Position: refs/heads/master@{#313797}

Powered by Google App Engine
This is Rietveld 408576698