src/lookup.cc - Issue 888623002: Property reconfiguring implemented. Tests added.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup.cc

Issue 888623002: Property reconfiguring implemented. Tests added. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/lookup.cc

diff --git a/src/lookup.cc b/src/lookup.cc

index c658a90e63fb816f831d7c82caa931579388cd01..46c1d59632313c6526a37e95747da78b4e5b692d 100644

--- a/src/lookup.cc

+++ b/src/lookup.cc

@@ -105,8 +105,8 @@ void LookupIterator::ReconfigureDataProperty(Handle<Object> value,

PropertyDetails details(attributes, v8::internal::DATA, 0);

JSObject::SetNormalizedProperty(holder, name(), value, details);

} else {

- holder_map_ = Map::ReconfigureDataProperty(holder_map_, descriptor_number(),

- attributes);

+ holder_map_ = Map::ReconfigureExistingProperty(

+ holder_map_, descriptor_number(), i::kData, attributes);

JSObject::MigrateToMap(holder, holder_map_);

}

« no previous file with comments | « no previous file | src/objects.h » ('j') | src/objects.cc » ('J')