test/cctest/test-log-stack-tracer.cc - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-log-stack-tracer.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-log-stack-tracer.cc

diff --git a/test/cctest/test-log-stack-tracer.cc b/test/cctest/test-log-stack-tracer.cc

index 714ad69c8d7ecee8b8da094761c18f20962d4a71..e4ca28212d5d3b398670b25b7a8db7b815fb2e2d 100644

--- a/test/cctest/test-log-stack-tracer.cc

+++ b/test/cctest/test-log-stack-tracer.cc

@@ -276,11 +276,11 @@ TEST(JsEntrySp) {

v8::HandleScope scope(CcTest::isolate());

v8::Local<v8::Context> context = CcTest::NewContext(TRACE_EXTENSION);

v8::Context::Scope context_scope(context);

- CHECK_EQ(0, i::TraceExtension::GetJsEntrySp());

+ CHECK(!i::TraceExtension::GetJsEntrySp());

CompileRun("a = 1; b = a + 1;");

- CHECK_EQ(0, i::TraceExtension::GetJsEntrySp());

+ CHECK(!i::TraceExtension::GetJsEntrySp());

CompileRun("js_entry_sp();");

- CHECK_EQ(0, i::TraceExtension::GetJsEntrySp());

+ CHECK(!i::TraceExtension::GetJsEntrySp());

CompileRun("js_entry_sp_level2();");

- CHECK_EQ(0, i::TraceExtension::GetJsEntrySp());

+ CHECK(!i::TraceExtension::GetJsEntrySp());

}

« no previous file with comments | « test/cctest/test-log.cc ('k') | test/cctest/test-macro-assembler-arm.cc » ('j') | no next file with comments »