test/cctest/test-deoptimization.cc - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-deoptimization.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-deoptimization.cc

diff --git a/test/cctest/test-deoptimization.cc b/test/cctest/test-deoptimization.cc

index a201ccd7e47d1b1725b2c99fd6e783e300991dcf..e4c8e03314461f54128747f64980eefee7c00646 100644

--- a/test/cctest/test-deoptimization.cc

+++ b/test/cctest/test-deoptimization.cc

@@ -395,7 +395,7 @@ UNINITIALIZED_TEST(DeoptimizeBinaryOperationADDString) {

v8::Handle<v8::Value> result = env->Global()->Get(v8_str("result"));

CHECK(result->IsString());

v8::String::Utf8Value utf8(result);

- CHECK_EQ("a+an X", *utf8);

+ CHECK_EQ(0, strcmp("a+an X", *utf8));

CHECK_EQ(0, Deoptimizer::GetDeoptimizedCodeCount(i_isolate));

}

isolate->Exit();

« no previous file with comments | « test/cctest/test-decls.cc ('k') | test/cctest/test-dtoa.cc » ('j') | no next file with comments »