test/cctest/compiler/test-node-cache.cc - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/test-node-cache.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/compiler/test-node-cache.cc

diff --git a/test/cctest/compiler/test-node-cache.cc b/test/cctest/compiler/test-node-cache.cc

index 835c028b38b2803dd5227ee8a7b2dd9ea3266895..b11e859cbc13eebea7456116cf0e685d613c8afb 100644

--- a/test/cctest/compiler/test-node-cache.cc

+++ b/test/cctest/compiler/test-node-cache.cc

@@ -17,7 +17,7 @@ TEST(Int32Constant_back_to_back) {

for (int i = -2000000000; i < 2000000000; i += 3315177) {

Node** pos = cache.Find(graph.zone(), i);

- CHECK_NE(NULL, pos);

+ CHECK(pos);

for (int j = 0; j < 3; j++) {

Node** npos = cache.Find(graph.zone(), i);

CHECK_EQ(pos, npos);

@@ -80,7 +80,7 @@ TEST(Int64Constant_back_to_back) {

for (int64_t i = -2000000000; i < 2000000000; i += 3315177) {