src/x64/macro-assembler-x64.cc - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/macro-assembler-x64.cc

diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc

index 3a477fc7937382ceae2ba1951f918683cb779c0e..d81a00fc92aa93b7e9adbd21ddc703ec4afc3360 100644

--- a/src/x64/macro-assembler-x64.cc

+++ b/src/x64/macro-assembler-x64.cc

@@ -2198,7 +2198,7 @@ void MacroAssembler::SelectNonSmi(Register dst,

Check(not_both_smis, kBothRegistersWereSmisInSelectNonSmi);

#endif

STATIC_ASSERT(kSmiTag == 0);

- DCHECK_EQ(0, Smi::FromInt(0));

+ DCHECK_EQ(static_cast<Smi*>(0), Smi::FromInt(0));

movl(kScratchRegister, Immediate(kSmiTagMask));

andp(kScratchRegister, src1);

testl(kScratchRegister, src2);

« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | src/x87/full-codegen-x87.cc » ('j') | no next file with comments »