src/unique.h - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/unique.h

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/unique.h

diff --git a/src/unique.h b/src/unique.h

index 321eb3683dbedac418dd442c9d9f30ce9a9257ba..b56ee84a33695488d696aa89d3ea6e58361a0570 100644

--- a/src/unique.h

+++ b/src/unique.h

@@ -49,7 +49,7 @@ class Unique {

// TODO(titzer): other immortable immovable objects are also fine.

DCHECK(!AllowHeapAllocation::IsAllowed() || handle->IsMap());

raw_address_ = reinterpret_cast<Address>(*handle);

- DCHECK_NE(raw_address_, NULL); // Non-null should imply non-zero address.

+ DCHECK_NOT_NULL(raw_address_); // Non-null should imply non-zero address.

}

handle_ = handle;

}

« no previous file with comments | « src/serialize.cc ('k') | src/v8.h » ('j') | no next file with comments »