src/runtime/runtime-array.cc - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-array.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-array.cc

diff --git a/src/runtime/runtime-array.cc b/src/runtime/runtime-array.cc

index 0ba1fa6cce0e977d961e7dbcad6daeec0bdf7bca..d1c1f30208f5bff89d42bc9c3194b920011a9ff0 100644

--- a/src/runtime/runtime-array.cc

+++ b/src/runtime/runtime-array.cc

@@ -851,7 +851,7 @@ RUNTIME_FUNCTION(Runtime_ArrayConcat) {

case FAST_HOLEY_ELEMENTS:

case FAST_ELEMENTS:

case DICTIONARY_ELEMENTS:

- DCHECK_EQ(0, length);

+ DCHECK_EQ(0u, length);

break;

default:

UNREACHABLE();

« no previous file with comments | « src/ppc/full-codegen-ppc.cc ('k') | src/serialize.h » ('j') | no next file with comments »