src/ic/x64/stub-cache-x64.cc - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/x64/stub-cache-x64.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/x64/stub-cache-x64.cc

diff --git a/src/ic/x64/stub-cache-x64.cc b/src/ic/x64/stub-cache-x64.cc

index f15635c6b9af30f6a2f77f97824c1c9a0ab9af06..4be0d5b33046dc365ab3b0a2d3d5affe3ae0c143 100644

--- a/src/ic/x64/stub-cache-x64.cc

+++ b/src/ic/x64/stub-cache-x64.cc

@@ -30,7 +30,7 @@ static void ProbeTable(Isolate* isolate, MacroAssembler* masm,

: kPointerSizeLog2 == StubCache::kCacheIndexShift);

ScaleFactor scale_factor = kPointerSize == kInt64Size ? times_2 : times_1;

- DCHECK_EQ(3 * kPointerSize, sizeof(StubCache::Entry));

+ DCHECK_EQ(3u * kPointerSize, sizeof(StubCache::Entry));

// The offset register holds the entry offset times four (due to masking

// and shifting optimizations).

ExternalReference key_offset(isolate->stub_cache()->key_reference(table));

« no previous file with comments | « src/ic/ic-state.h ('k') | src/isolate.cc » ('j') | no next file with comments »