src/ia32/full-codegen-ia32.cc - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 81cd11f469186b2b428a827c3816e7dd47edfc02..af5fe45e25242eb7469f1bb99ebbea752c4a04c4 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -3708,7 +3708,7 @@ void FullCodeGenerator::EmitValueOf(CallRuntime* expr) {

void FullCodeGenerator::EmitDateField(CallRuntime* expr) {

ZoneList<Expression*>* args = expr->arguments();

DCHECK(args->length() == 2);

- DCHECK_NE(NULL, args->at(1)->AsLiteral());

+ DCHECK_NOT_NULL(args->at(1)->AsLiteral());

Smi* index = Smi::cast(*(args->at(1)->AsLiteral()->value()));

VisitForAccumulatorValue(args->at(0)); // Load the object.

@@ -4064,7 +4064,7 @@ void FullCodeGenerator::EmitGetFromCache(CallRuntime* expr) {

ZoneList<Expression*>* args = expr->arguments();

DCHECK_EQ(2, args->length());

- DCHECK_NE(NULL, args->at(0)->AsLiteral());

+ DCHECK_NOT_NULL(args->at(0)->AsLiteral());

int cache_id = Smi::cast(*(args->at(0)->AsLiteral()->value()))->value();

Handle<FixedArray> jsfunction_result_caches(

« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »