src/compiler/node.cc - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/node.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/node.cc

diff --git a/src/compiler/node.cc b/src/compiler/node.cc

index a4680e4636f1630219fcfc4041e3aef1f260edbf..d38e9ceff7e432c718a9d25f4c658b23d8e1c8db 100644

--- a/src/compiler/node.cc

+++ b/src/compiler/node.cc

@@ -134,7 +134,7 @@ void Node::ReplaceUses(Node* replace_to) {

use->from->GetInputRecordPtr(use->input_index)->to = replace_to;

}

if (!replace_to->last_use_) {

- DCHECK_EQ(nullptr, replace_to->first_use_);

+ DCHECK(!replace_to->first_use_);

replace_to->first_use_ = first_use_;

replace_to->last_use_ = last_use_;

} else if (first_use_) {

« no previous file with comments | « src/compiler/move-optimizer.cc ('k') | src/compiler/osr.cc » ('j') | no next file with comments »