Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: src/compiler/js-inlining.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/instruction-selector.cc ('k') | src/compiler/loop-peeling.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-inlining.cc
diff --git a/src/compiler/js-inlining.cc b/src/compiler/js-inlining.cc
index d45877b901e28efb923756f44eb79f1a0beecf32..42fc58ec384b3f41671fcc2010f7ea73025d1d5e 100644
--- a/src/compiler/js-inlining.cc
+++ b/src/compiler/js-inlining.cc
@@ -84,7 +84,7 @@ class Inlinee {
// Counts only formal parameters.
size_t formal_parameters() {
- DCHECK_GE(total_parameters(), 3);
+ DCHECK_GE(total_parameters(), 3u);
return total_parameters() - 3;
}
@@ -176,7 +176,7 @@ class CopyVisitor : public NullNodeVisitor {
if (copy == NULL) {
copy = GetSentinel(original);
}
- DCHECK_NE(NULL, copy);
+ DCHECK(copy);
return copy;
}
@@ -193,7 +193,7 @@ class CopyVisitor : public NullNodeVisitor {
Node* sentinel = sentinels_[id];
if (sentinel == NULL) continue;
Node* copy = copies_[id];
- DCHECK_NE(NULL, copy);
+ DCHECK(copy);
sentinel->ReplaceUses(copy);
}
}
« no previous file with comments | « src/compiler/instruction-selector.cc ('k') | src/compiler/loop-peeling.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698