src/compiler/arm/code-generator-arm.cc - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/arm/code-generator-arm.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/arm/code-generator-arm.cc

diff --git a/src/compiler/arm/code-generator-arm.cc b/src/compiler/arm/code-generator-arm.cc

index 51ac2070c8f81de33fadaf5e2965c93439475235..894584b8d39b9ffbeb4c454b5863b58518664800 100644

--- a/src/compiler/arm/code-generator-arm.cc

+++ b/src/compiler/arm/code-generator-arm.cc

@@ -745,7 +745,7 @@ void CodeGenerator::AssembleArchBoolean(Instruction* instr,

// Materialize a full 32-bit 1 or 0 value. The result register is always the

// last output of the instruction.

- DCHECK_NE(0, instr->OutputCount());

+ DCHECK_NE(0u, instr->OutputCount());

Condition cc = FlagsConditionToCondition(condition);

__ mov(reg, Operand(0));

« no previous file with comments | « src/compiler.cc ('k') | src/compiler/arm/instruction-selector-arm.cc » ('j') | no next file with comments »