src/arm64/lithium-codegen-arm64.cc - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/lithium-codegen-arm64.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm64/lithium-codegen-arm64.cc

diff --git a/src/arm64/lithium-codegen-arm64.cc b/src/arm64/lithium-codegen-arm64.cc

index 8a300e29b890adf9474b32e83d294ea9d5224fd3..c49ecb761f51d060e2d524412328f95abb3392b6 100644

--- a/src/arm64/lithium-codegen-arm64.cc

+++ b/src/arm64/lithium-codegen-arm64.cc

@@ -2820,7 +2820,7 @@ void LCodeGen::DoDivI(LDivI* instr) {

__ Sdiv(result, dividend, divisor);

if (hdiv->CheckFlag(HValue::kAllUsesTruncatingToInt32)) {

- DCHECK_EQ(NULL, instr->temp());

+ DCHECK(!instr->temp());

return;

}

« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/arm64/macro-assembler-arm64.cc » ('j') | no next file with comments »