src/api.cc - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index fd84341b1e335bb25389617a5543305f1d76599f..d4eee16181ca22bfb3a666bb938b739c7fc4a50a 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -4996,7 +4996,7 @@ void v8::Object::SetInternalField(int index, v8::Handle<Value> value) {

if (!InternalFieldOK(obj, index, location)) return;

i::Handle<i::Object> val = Utils::OpenHandle(*value);

obj->SetInternalField(index, *val);

- DCHECK_EQ(value, GetInternalField(index));

+ DCHECK(value->Equals(GetInternalField(index)));

}

« no previous file with comments | « include/v8-profiler.h ('k') | src/arm/code-stubs-arm.cc » ('j') | no next file with comments »