src/v8.h - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8.h

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix slow dchecks. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/v8.h

diff --git a/src/v8.h b/src/v8.h

index 4922a4db1ebf74f26998f47263336a5b3dfb5b48..fea209e39f873e873bf2f10808a5d01c61366a60 100644

--- a/src/v8.h

+++ b/src/v8.h

@@ -73,7 +73,7 @@ class V8 : public AllStatic {

}

static void SetArrayBufferAllocator(v8::ArrayBuffer::Allocator *allocator) {

- CHECK_EQ(NULL, array_buffer_allocator_);

+ CHECK(!array_buffer_allocator_);

array_buffer_allocator_ = allocator;

}

« src/jsregexp.cc ('K') | « src/unique.h ('k') | src/x64/assembler-x64.cc » ('j') | no next file with comments »