Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: src/scanner.h

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix slow dchecks. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/scanner.h
diff --git a/src/scanner.h b/src/scanner.h
index 8537c5308c9f73e8dbf2f5f97e8188f195d531cc..2b09eee60aeac430a5bddca01e41887cf429ace6 100644
--- a/src/scanner.h
+++ b/src/scanner.h
@@ -390,11 +390,11 @@ class Scanner {
return current_.literal_chars->length() != source_length;
}
bool is_literal_contextual_keyword(Vector<const char> keyword) {
- DCHECK_NOT_NULL(current_.literal_chars);
+ DCHECK(current_.literal_chars);
return current_.literal_chars->is_contextual_keyword(keyword);
}
bool is_next_contextual_keyword(Vector<const char> keyword) {
- DCHECK_NOT_NULL(next_.literal_chars);
+ DCHECK(next_.literal_chars);
return next_.literal_chars->is_contextual_keyword(keyword);
}
@@ -536,17 +536,17 @@ class Scanner {
}
INLINE(void AddLiteralChar(uc32 c)) {
- DCHECK_NOT_NULL(next_.literal_chars);
+ DCHECK(next_.literal_chars);
next_.literal_chars->AddChar(c);
}
INLINE(void AddRawLiteralChar(uc32 c)) {
- DCHECK_NOT_NULL(next_.raw_literal_chars);
+ DCHECK(next_.raw_literal_chars);
next_.raw_literal_chars->AddChar(c);
}
INLINE(void ReduceRawLiteralLength(int delta)) {
- DCHECK_NOT_NULL(next_.raw_literal_chars);
+ DCHECK(next_.raw_literal_chars);
next_.raw_literal_chars->ReduceLength(delta);
}
@@ -612,45 +612,45 @@ class Scanner {
// These functions only give the correct result if the literal was scanned
// when a LiteralScope object is alive.
Vector<const uint8_t> literal_one_byte_string() {
- DCHECK_NOT_NULL(current_.literal_chars);
+ DCHECK(current_.literal_chars);
return current_.literal_chars->one_byte_literal();
}
Vector<const uint16_t> literal_two_byte_string() {
- DCHECK_NOT_NULL(current_.literal_chars);
+ DCHECK(current_.literal_chars);
return current_.literal_chars->two_byte_literal();
}
bool is_literal_one_byte() {
- DCHECK_NOT_NULL(current_.literal_chars);
+ DCHECK(current_.literal_chars);
return current_.literal_chars->is_one_byte();
}
int literal_length() const {
- DCHECK_NOT_NULL(current_.literal_chars);
+ DCHECK(current_.literal_chars);
return current_.literal_chars->length();
}
// Returns the literal string for the next token (the token that
// would be returned if Next() were called).
Vector<const uint8_t> next_literal_one_byte_string() {
- DCHECK_NOT_NULL(next_.literal_chars);
+ DCHECK(next_.literal_chars);
return next_.literal_chars->one_byte_literal();
}
Vector<const uint16_t> next_literal_two_byte_string() {
- DCHECK_NOT_NULL(next_.literal_chars);
+ DCHECK(next_.literal_chars);
return next_.literal_chars->two_byte_literal();
}
bool is_next_literal_one_byte() {
- DCHECK_NOT_NULL(next_.literal_chars);
+ DCHECK(next_.literal_chars);
return next_.literal_chars->is_one_byte();
}
Vector<const uint8_t> raw_literal_one_byte_string() {
- DCHECK_NOT_NULL(current_.raw_literal_chars);
+ DCHECK(current_.raw_literal_chars);
return current_.raw_literal_chars->one_byte_literal();
}
Vector<const uint16_t> raw_literal_two_byte_string() {
- DCHECK_NOT_NULL(current_.raw_literal_chars);
+ DCHECK(current_.raw_literal_chars);
return current_.raw_literal_chars->two_byte_literal();
}
bool is_raw_literal_one_byte() {
- DCHECK_NOT_NULL(current_.raw_literal_chars);
+ DCHECK(current_.raw_literal_chars);
return current_.raw_literal_chars->is_one_byte();
}
« src/jsregexp.cc ('K') | « src/runtime/runtime-array.cc ('k') | src/serialize.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698