src/ostreams.cc - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ostreams.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix slow dchecks. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ostreams.cc

diff --git a/src/ostreams.cc b/src/ostreams.cc

index 4f28141d71aa4667bafd7f4742d97d26b5587636..0fcdf628129502f03730b8bfdde2b0125edf4027 100644

--- a/src/ostreams.cc

+++ b/src/ostreams.cc

@@ -35,7 +35,7 @@ std::streamsize OFStreamBase::xsputn(const char* s, std::streamsize n) {

OFStream::OFStream(FILE* f) : std::ostream(nullptr), buf_(f) {

- DCHECK_NOT_NULL(f);

+ DCHECK(f);

rdbuf(&buf_);

}

« src/jsregexp.cc ('K') | « src/optimizing-compiler-thread.cc ('k') | src/parser.h » ('j') | no next file with comments »