src/ia32/lithium-codegen-ia32.cc - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix slow dchecks. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 357928193cb548529a128f574fb987ba90ece558..5f0db2b49062c47bf50c16691ee727f6fde8cdc9 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -4387,7 +4387,7 @@ void LCodeGen::DoTransitionElementsKind(LTransitionElementsKind* instr) {

__ mov(FieldOperand(object_reg, HeapObject::kMapOffset),

Immediate(to_map));

// Write barrier.

- DCHECK_NE(instr->temp(), NULL);

+ DCHECK(instr->temp());

__ RecordWriteForMap(object_reg, to_map, new_map_reg,

ToRegister(instr->temp()),

kDontSaveFPRegs);

« src/checks.cc ('K') | « src/ia32/full-codegen-ia32.cc ('k') | src/ic/handler-compiler.cc » ('j') | src/jsregexp.cc » ('J')