Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: test/cctest/test-version.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-symbols.cc ('k') | test/cctest/trace-extension.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 static void CheckVersion(int major, int minor, int build, 52 static void CheckVersion(int major, int minor, int build,
53 int patch, bool candidate, 53 int patch, bool candidate,
54 const char* expected_version_string, 54 const char* expected_version_string,
55 const char* expected_generic_soname) { 55 const char* expected_generic_soname) {
56 static v8::internal::EmbeddedVector<char, 128> version_str; 56 static v8::internal::EmbeddedVector<char, 128> version_str;
57 static v8::internal::EmbeddedVector<char, 128> soname_str; 57 static v8::internal::EmbeddedVector<char, 128> soname_str;
58 58
59 // Test version without specific SONAME. 59 // Test version without specific SONAME.
60 SetVersion(major, minor, build, patch, candidate, ""); 60 SetVersion(major, minor, build, patch, candidate, "");
61 Version::GetString(version_str); 61 Version::GetString(version_str);
62 CHECK_EQ(expected_version_string, version_str.start()); 62 CHECK_EQ(0, strcmp(expected_version_string, version_str.start()));
63 Version::GetSONAME(soname_str); 63 Version::GetSONAME(soname_str);
64 CHECK_EQ(expected_generic_soname, soname_str.start()); 64 CHECK_EQ(0, strcmp(expected_generic_soname, soname_str.start()));
65 65
66 // Test version with specific SONAME. 66 // Test version with specific SONAME.
67 const char* soname = "libv8.so.1"; 67 const char* soname = "libv8.so.1";
68 SetVersion(major, minor, build, patch, candidate, soname); 68 SetVersion(major, minor, build, patch, candidate, soname);
69 Version::GetString(version_str); 69 Version::GetString(version_str);
70 CHECK_EQ(expected_version_string, version_str.start()); 70 CHECK_EQ(0, strcmp(expected_version_string, version_str.start()));
71 Version::GetSONAME(soname_str); 71 Version::GetSONAME(soname_str);
72 CHECK_EQ(soname, soname_str.start()); 72 CHECK_EQ(0, strcmp(soname, soname_str.start()));
73 } 73 }
74 74
75 75
76 TEST(VersionString) { 76 TEST(VersionString) {
77 #ifdef USE_SIMULATOR 77 #ifdef USE_SIMULATOR
78 CheckVersion(0, 0, 0, 0, false, "0.0.0 SIMULATOR", "libv8-0.0.0.so"); 78 CheckVersion(0, 0, 0, 0, false, "0.0.0 SIMULATOR", "libv8-0.0.0.so");
79 CheckVersion(0, 0, 0, 0, true, 79 CheckVersion(0, 0, 0, 0, true,
80 "0.0.0 (candidate) SIMULATOR", "libv8-0.0.0-candidate.so"); 80 "0.0.0 (candidate) SIMULATOR", "libv8-0.0.0-candidate.so");
81 CheckVersion(1, 0, 0, 0, false, "1.0.0 SIMULATOR", "libv8-1.0.0.so"); 81 CheckVersion(1, 0, 0, 0, false, "1.0.0 SIMULATOR", "libv8-1.0.0.so");
82 CheckVersion(1, 0, 0, 0, true, 82 CheckVersion(1, 0, 0, 0, true,
(...skipping 12 matching lines...) Expand all
95 CheckVersion(1, 0, 0, 0, true, 95 CheckVersion(1, 0, 0, 0, true,
96 "1.0.0 (candidate)", "libv8-1.0.0-candidate.so"); 96 "1.0.0 (candidate)", "libv8-1.0.0-candidate.so");
97 CheckVersion(1, 0, 0, 1, false, "1.0.0.1", "libv8-1.0.0.1.so"); 97 CheckVersion(1, 0, 0, 1, false, "1.0.0.1", "libv8-1.0.0.1.so");
98 CheckVersion(1, 0, 0, 1, true, 98 CheckVersion(1, 0, 0, 1, true,
99 "1.0.0.1 (candidate)", "libv8-1.0.0.1-candidate.so"); 99 "1.0.0.1 (candidate)", "libv8-1.0.0.1-candidate.so");
100 CheckVersion(2, 5, 10, 7, false, "2.5.10.7", "libv8-2.5.10.7.so"); 100 CheckVersion(2, 5, 10, 7, false, "2.5.10.7", "libv8-2.5.10.7.so");
101 CheckVersion(2, 5, 10, 7, true, 101 CheckVersion(2, 5, 10, 7, true,
102 "2.5.10.7 (candidate)", "libv8-2.5.10.7-candidate.so"); 102 "2.5.10.7 (candidate)", "libv8-2.5.10.7-candidate.so");
103 #endif 103 #endif
104 } 104 }
OLDNEW
« no previous file with comments | « test/cctest/test-symbols.cc ('k') | test/cctest/trace-extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698