test/cctest/test-global-object.cc - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/cctest/test-global-object.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « test/cctest/test-func-name-inference.cc ('k') | test/cctest/test-hashmap.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 the V8 project authors. All rights reserved.	1 // Copyright 2013 the V8 project authors. All rights reserved.

2 // Redistribution and use in source and binary forms, with or without	2 // Redistribution and use in source and binary forms, with or without

3 // modification, are permitted provided that the following conditions are	3 // modification, are permitted provided that the following conditions are

4 // met:	4 // met:

5 //	5 //

6 // * Redistributions of source code must retain the above copyright	6 // * Redistributions of source code must retain the above copyright

7 // notice, this list of conditions and the following disclaimer.	7 // notice, this list of conditions and the following disclaimer.

8 // * Redistributions in binary form must reproduce the above	8 // * Redistributions in binary form must reproduce the above

9 // copyright notice, this list of conditions and the following	9 // copyright notice, this list of conditions and the following

10 // disclaimer in the documentation and/or other materials provided	10 // disclaimer in the documentation and/or other materials provided

(...skipping 29 matching lines...) Expand all Loading...
40 v8::TryCatch try_catch;	40 v8::TryCatch try_catch;

41 v8::Local<v8::Script> script = v8_compile("\"use strict\"; x = 42;");	41 v8::Local<v8::Script> script = v8_compile("\"use strict\"; x = 42;");

42 v8::Handle<v8::Object> proto = v8::Object::New(CcTest::isolate());	42 v8::Handle<v8::Object> proto = v8::Object::New(CcTest::isolate());

43 v8::Handle<v8::Object> global =	43 v8::Handle<v8::Object> global =

44 context->Global()->GetPrototype().As<v8::Object>();	44 context->Global()->GetPrototype().As<v8::Object>();

45 proto->Set(var_name, v8_num(100));	45 proto->Set(var_name, v8_num(100));

46 global->SetPrototype(proto);	46 global->SetPrototype(proto);

47 script->Run();	47 script->Run();

48 CHECK(try_catch.HasCaught());	48 CHECK(try_catch.HasCaught());

49 v8::String::Utf8Value exception(try_catch.Exception());	49 v8::String::Utf8Value exception(try_catch.Exception());

50 CHECK_EQ("ReferenceError: x is not defined", *exception);	50 CHECK_EQ(0, strcmp("ReferenceError: x is not defined", *exception));

51 }	51 }

OLD	NEW