Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: src/compiler/ia32/code-generator-ia32.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/control-reducer.cc ('k') | src/compiler/ia32/instruction-selector-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/compiler/code-generator-impl.h" 7 #include "src/compiler/code-generator-impl.h"
8 #include "src/compiler/gap-resolver.h" 8 #include "src/compiler/gap-resolver.h"
9 #include "src/compiler/node-matchers.h" 9 #include "src/compiler/node-matchers.h"
10 #include "src/compiler/osr.h" 10 #include "src/compiler/osr.h"
(...skipping 750 matching lines...) Expand 10 before | Expand all | Expand 10 after
761 761
762 // Assembles boolean materializations after an instruction. 762 // Assembles boolean materializations after an instruction.
763 void CodeGenerator::AssembleArchBoolean(Instruction* instr, 763 void CodeGenerator::AssembleArchBoolean(Instruction* instr,
764 FlagsCondition condition) { 764 FlagsCondition condition) {
765 IA32OperandConverter i(this, instr); 765 IA32OperandConverter i(this, instr);
766 Label done; 766 Label done;
767 767
768 // Materialize a full 32-bit 1 or 0 value. The result register is always the 768 // Materialize a full 32-bit 1 or 0 value. The result register is always the
769 // last output of the instruction. 769 // last output of the instruction.
770 Label check; 770 Label check;
771 DCHECK_NE(0, instr->OutputCount()); 771 DCHECK_NE(0u, instr->OutputCount());
772 Register reg = i.OutputRegister(instr->OutputCount() - 1); 772 Register reg = i.OutputRegister(instr->OutputCount() - 1);
773 Condition cc = no_condition; 773 Condition cc = no_condition;
774 switch (condition) { 774 switch (condition) {
775 case kUnorderedEqual: 775 case kUnorderedEqual:
776 __ j(parity_odd, &check, Label::kNear); 776 __ j(parity_odd, &check, Label::kNear);
777 __ Move(reg, Immediate(0)); 777 __ Move(reg, Immediate(0));
778 __ jmp(&done, Label::kNear); 778 __ jmp(&done, Label::kNear);
779 // Fall through. 779 // Fall through.
780 case kEqual: 780 case kEqual:
781 cc = equal; 781 cc = equal;
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
1233 } 1233 }
1234 } 1234 }
1235 MarkLazyDeoptSite(); 1235 MarkLazyDeoptSite();
1236 } 1236 }
1237 1237
1238 #undef __ 1238 #undef __
1239 1239
1240 } // namespace compiler 1240 } // namespace compiler
1241 } // namespace internal 1241 } // namespace internal
1242 } // namespace v8 1242 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/control-reducer.cc ('k') | src/compiler/ia32/instruction-selector-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698