Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: src/compiler.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix slow dchecks. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/compiler.h" 7 #include "src/compiler.h"
8 8
9 #include "src/ast-numbering.h" 9 #include "src/ast-numbering.h"
10 #include "src/ast-this-access-visitor.h" 10 #include "src/ast-this-access-visitor.h"
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 if (GetFlag(kDisableFutureOptimization)) { 200 if (GetFlag(kDisableFutureOptimization)) {
201 shared_info()->DisableOptimization(bailout_reason()); 201 shared_info()->DisableOptimization(bailout_reason());
202 } 202 }
203 delete deferred_handles_; 203 delete deferred_handles_;
204 delete no_frame_ranges_; 204 delete no_frame_ranges_;
205 if (ast_value_factory_owned_) delete ast_value_factory_; 205 if (ast_value_factory_owned_) delete ast_value_factory_;
206 #ifdef DEBUG 206 #ifdef DEBUG
207 // Check that no dependent maps have been added or added dependent maps have 207 // Check that no dependent maps have been added or added dependent maps have
208 // been rolled back or committed. 208 // been rolled back or committed.
209 for (int i = 0; i < DependentCode::kGroupCount; i++) { 209 for (int i = 0; i < DependentCode::kGroupCount; i++) {
210 DCHECK_EQ(NULL, dependencies_[i]); 210 DCHECK(!dependencies_[i]);
211 } 211 }
212 #endif // DEBUG 212 #endif // DEBUG
213 } 213 }
214 214
215 215
216 void CompilationInfo::CommitDependencies(Handle<Code> code) { 216 void CompilationInfo::CommitDependencies(Handle<Code> code) {
217 for (int i = 0; i < DependentCode::kGroupCount; i++) { 217 for (int i = 0; i < DependentCode::kGroupCount; i++) {
218 ZoneList<Handle<HeapObject> >* group_objects = dependencies_[i]; 218 ZoneList<Handle<HeapObject> >* group_objects = dependencies_[i];
219 if (group_objects == NULL) continue; 219 if (group_objects == NULL) continue;
220 DCHECK(!object_wrapper_.is_null()); 220 DCHECK(!object_wrapper_.is_null());
(...skipping 1362 matching lines...) Expand 10 before | Expand all | Expand 10 after
1583 AllowHandleDereference allow_deref; 1583 AllowHandleDereference allow_deref;
1584 bool tracing_on = info()->IsStub() 1584 bool tracing_on = info()->IsStub()
1585 ? FLAG_trace_hydrogen_stubs 1585 ? FLAG_trace_hydrogen_stubs
1586 : (FLAG_trace_hydrogen && 1586 : (FLAG_trace_hydrogen &&
1587 info()->closure()->PassesFilter(FLAG_trace_hydrogen_filter)); 1587 info()->closure()->PassesFilter(FLAG_trace_hydrogen_filter));
1588 return (tracing_on && 1588 return (tracing_on &&
1589 base::OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL); 1589 base::OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL);
1590 } 1590 }
1591 1591
1592 } } // namespace v8::internal 1592 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698