Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 888593002: Revert of Roll WebRTC 8176:8203, Libjingle 8174:8202 (Closed)

Created:
5 years, 10 months ago by please use gerrit instead
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll WebRTC 8176:8203, Libjingle 8174:8202 (patchset #2 id:20001 of https://codereview.chromium.org/885003003/) Reason for revert: Appears to have broken Mac browser tests: - WebRtcSimulcastBrowserTest.TestVgaReturnsTwoSimulcastStreams - WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs [75316:29699:0129/074049:FATAL:overuse_frame_detector.cc(388)] Check failed: processing_thread_.CalledOnValidThread(). 0 libbase.dylib 0x0000000119eaf88f base::debug::StackTrace::StackTrace() + 47 1 libbase.dylib 0x0000000119eaf8e3 base::debug::StackTrace::StackTrace() + 35 2 libbase.dylib 0x0000000119f09076 logging::LogMessage::~LogMessage() + 70 3 libbase.dylib 0x0000000119f080c3 logging::LogMessage::~LogMessage() + 35 4 libcontent.dylib 0x000000012ce82cd5 webrtc::OveruseFrameDetector::TimeUntilNextProcess() + 245 5 libcontent.dylib 0x000000012c8dfdfd webrtc::ProcessThreadImpl::Process() + 525 6 libcontent.dylib 0x000000012c8df836 webrtc::ProcessThreadImpl::Run(void*) + 38 7 libcontent.dylib 0x000000012c6ce390 webrtc::ThreadPosix::Run() + 288 8 libcontent.dylib 0x000000012c6ce076 webrtc::StartThread(void*) + 38 9 libsystem_pthread.dylib 0x00007fff8fe5f899 _pthread_body + 138 10 libsystem_pthread.dylib 0x00007fff8fe5f72a _pthread_struct_init + 0 11 libsystem_pthread.dylib 0x00007fff8fe63fc9 thread_start + 13 https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/2438 Original issue's description: > Roll WebRTC 8176:8203, Libjingle 8174:8202 > > WebRTC 8176:8203 > Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/9fbfe8f..7b9e261 > > Libjingle 8174:8202 > Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/6660ffc..237ae43 > > TBR=kjellander@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/8aa707b5aa26cead2ab4791672163337c92f904b TBR=kjellander@chromium.org,tommi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/23f2a56e6ed4103fc3b8d20fe8f2f4f272cab311 Cr-Commit-Position: refs/heads/master@{#313714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M DEPS View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_not_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_not_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/libjingle/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
please use gerrit instead
Created Revert of Roll WebRTC 8176:8203, Libjingle 8174:8202
5 years, 10 months ago (2015-01-29 15:55:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888593002/1
5 years, 10 months ago (2015-01-29 15:56:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 15:57:31 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 15:58:34 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23f2a56e6ed4103fc3b8d20fe8f2f4f272cab311
Cr-Commit-Position: refs/heads/master@{#313714}

Powered by Google App Engine
This is Rietveld 408576698