Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: content/browser/devtools/protocol/frame_recorder.h

Issue 888573002: DevTools: FrameRecorder: add cancelRecordingFrames command (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/protocol/frame_recorder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/frame_recorder.h
diff --git a/content/browser/devtools/protocol/frame_recorder.h b/content/browser/devtools/protocol/frame_recorder.h
index ac082b1e3e1c5445d26fb2a44d4e800cd165c5da..56926efc09530ae5917adac589665140e19c11f3 100644
--- a/content/browser/devtools/protocol/frame_recorder.h
+++ b/content/browser/devtools/protocol/frame_recorder.h
@@ -6,9 +6,11 @@
#define CONTENT_BROWSER_DEVTOOLS_PROTOCOL_FRAME_RECORDER_H_
#include <string>
+#include <utility>
#include <vector>
#include "base/callback.h"
+#include "base/cancelable_callback.h"
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "base/time/time.h"
@@ -24,6 +26,8 @@ class RenderViewHostImpl;
namespace devtools {
namespace page {
+using EncodedFrame = std::pair<std::string, double>;
+
class FrameRecorder {
public:
using Response = DevToolsProtocolClient::Response;
@@ -35,6 +39,7 @@ class FrameRecorder {
Response StartRecordingFrames(int max_frame_count);
Response StopRecordingFrames(StopRecordingFramesCallback callback);
+ Response CancelRecordingFrames();
void SetRenderViewHost(RenderViewHostImpl* host);
void OnSwapCompositorFrame();
@@ -47,7 +52,7 @@ class FrameRecorder {
};
void FrameCaptured(const SkBitmap& bitmap, ReadbackResponse response);
- void FrameEncoded(double timestamp, const std::string& encoded_frame);
+ void FrameEncoded(const scoped_ptr<EncodedFrame>& encoded_frame);
void MaybeSendResponse();
RenderViewHostImpl* host_;
@@ -59,6 +64,8 @@ class FrameRecorder {
base::Time last_captured_frame_timestamp_;
std::vector<scoped_refptr<devtools::page::RecordedFrame>> frames_;
+ base::CancelableCallback<void(const scoped_ptr<EncodedFrame>&)>
+ frame_encoded_callback_;
base::WeakPtrFactory<FrameRecorder> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(FrameRecorder);
« no previous file with comments | « no previous file | content/browser/devtools/protocol/frame_recorder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698