Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 888513003: Move Push-related Blink API headers into their own directory. (Closed)

Created:
5 years, 10 months ago by Peter Beverloo
Modified:
5 years, 10 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move Push-related Blink API headers into their own directory. This allows the Push APIs to be covered by a push OWNER on top of the other public/ OWNERS. Note that deprecation of WebPushRegistration is not handled in this patch, as it makes the Chromium-side too noisy. This is part of a three-sided patch: [1] This patch. [2] https://codereview.chromium.org/894683002/ [3] https://codereview.chromium.org/871643005/ BUG=453032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189499

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -187 lines) Patch
M Source/modules/push_messaging/PushController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/push_messaging/PushError.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/push_messaging/PushManager.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/push_messaging/PushPermissionStatusCallbacks.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/push_messaging/PushSubscription.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M public/platform/WebPushClient.h View 1 chunk +1 line, -31 lines 0 comments Download
M public/platform/WebPushError.h View 1 chunk +1 line, -33 lines 0 comments Download
M public/platform/WebPushPermissionStatus.h View 1 chunk +1 line, -20 lines 0 comments Download
M public/platform/WebPushProvider.h View 1 chunk +1 line, -49 lines 0 comments Download
M public/platform/WebPushRegistration.h View 1 1 chunk +1 line, -17 lines 0 comments Download
M public/platform/WebPushSubscription.h View 1 chunk +1 line, -25 lines 0 comments Download
A + public/platform/modules/push_messaging/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + public/platform/modules/push_messaging/WebPushClient.h View 1 chunk +1 line, -1 line 0 comments Download
A + public/platform/modules/push_messaging/WebPushError.h View 1 chunk +1 line, -1 line 0 comments Download
A + public/platform/modules/push_messaging/WebPushPermissionStatus.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/push_messaging/WebPushProvider.h View 1 chunk +1 line, -1 line 0 comments Download
A + public/platform/modules/push_messaging/WebPushRegistration.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + public/platform/modules/push_messaging/WebPushSubscription.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Peter Beverloo
+mvanouwerkerk for Push API. +jochen for the public/ module changes for Push API. https://codereview.chromium.org/888513003/diff/20001/public/platform/modules/push_messaging/OWNERS File ...
5 years, 10 months ago (2015-02-02 12:50:08 UTC) #2
Mike West
LGTM.
5 years, 10 months ago (2015-02-02 13:18:44 UTC) #4
Michael van Ouwerkerk
lgtm
5 years, 10 months ago (2015-02-02 13:56:01 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-04 12:34:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888513003/40001
5 years, 10 months ago (2015-02-04 12:35:07 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 13:56:36 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189499

Powered by Google App Engine
This is Rietveld 408576698