Add support for sync* and yield

runtime/lib/core_patch.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "dart:math";
 import "dart:typed_data";
 
 // We need to pass the exception object as second parameter to the continuation.
 // See vm/ast_transformer.cc for usage.
 void  _asyncCatchHelper(catchFunction, continuation) {
   catchFunction((e) => continuation(null, e));
 }
 
 // The members of this class are cloned and added to each class that
 // represents an enum type.
 class _EnumHelper {
   // Declare the list of enum value names private. When this field is
   // cloned into a user-defined enum class, the field will be inaccessible
   // because of the library-specific name suffix. The toString() function
   // below can access it because it uses the same name suffix.
   static const List<String> _enum_names = null;
   String toString() => _enum_names[index];
 }
+
+
+class _SyncIterable extends IterableBase {
+  final moveNextFn;
+
+  const _SyncIterable(this.moveNextFn);
+
+  get iterator {
+    return new _SyncIterator(moveNextFn._clone());
+  }
+}
+
+class _SyncIterator implements Iterator {
+  var isYieldEach;

[srdjan, 2015/02/04 19:29:12]

Please add comment who sets isYieldEach. Also maybe add some comments to both
_SyncIterable and _SyncIterator.

[hausner, 2015/02/04 22:09:23]

Done.

+  var yieldEachIterator = null;
+  var current = null;

[srdjan, 2015/02/04 19:29:12]

I think null is the default initialization for all fields, you do not need to
explicitly do it.

[hausner, 2015/02/04 22:09:23]

Done.

+  var moveNextFn;

[srdjan, 2015/02/04 19:29:12]

Does the spec say anything about the type of moveNextFn? If so, please use type.

[hausner, 2015/02/04 22:09:23]

I don't want to use types. The type checks are unnecessary runtime overhead.

+
+  _SyncIterator(this.moveNextFn);
+
+  moveNext() {

[srdjan, 2015/02/04 19:29:12]

bool moveNext() {

[hausner, 2015/02/04 22:09:24]

Done.

+    if (moveNextFn == null) {
+      return false;
+    }
+    for(;;) {

[srdjan, 2015/02/04 19:29:12]

What is the advantage of "for(;;)" vs "while(true)"? (I find the later more
readable).

[hausner, 2015/02/04 22:09:23]

Done.

+      if (yieldEachIterator != null) {
+        if (yieldEachIterator.moveNext()) {
+          current = yieldEachIterator.current;
+          return true;
+        }
+        yieldEachIterator = null;
+      }
+      isYieldEach = false;
+      if (!moveNextFn(this)) {
+        moveNextFn = null;
+        current = null;
+        return false;
+      }
+      if (isYieldEach && (current is Iterable)) {
+        yieldEachIterator = current.iterator;
+        continue;
+      }
+      return true;    
+    }
+  }
+}