Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2722)

Unified Diff: remoting/webapp/unittests/it2me_helpee_channel_unittest.js

Issue 888323002: Improve HRD first run experience (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ready for Checkin Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/js_proto/chrome_proto.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/unittests/it2me_helpee_channel_unittest.js
diff --git a/remoting/webapp/unittests/it2me_helpee_channel_unittest.js b/remoting/webapp/unittests/it2me_helpee_channel_unittest.js
index 4ccfb08e74a768d3d794dc9e7411b78fad37e07d..3a8cb9627b67d0fa9187aa1bea67363c91e3c639 100644
--- a/remoting/webapp/unittests/it2me_helpee_channel_unittest.js
+++ b/remoting/webapp/unittests/it2me_helpee_channel_unittest.js
@@ -129,8 +129,11 @@ QUnit.asyncTest('connect() should return access code',
function() {
// Stubs authentication.
sinon.stub(base, 'isAppsV2').returns(true);
- sinon.stub(remoting.MessageWindow, 'showConfirmWindow')
- .callsArgWith(4, 1 /* 1 for OK. */);
+ sinon.stub(remoting.HangoutConsentDialog, 'getInstance').returns({
+ show : function() {
+ return Promise.resolve();
+ }
+ });
sinon.stub(chrome.identity, 'getAuthToken')
.callsArgWith(1, 'token');
// Stubs Host behavior.
@@ -142,7 +145,8 @@ QUnit.asyncTest('connect() should return access code',
var MessageTypes = remoting.It2MeHelpeeChannel.HangoutMessageTypes;
hangoutPort.onMessage.mock$fire({
method: MessageTypes.CONNECT,
- email: 'test@chromium.org'
+ email: 'test@chromium.org',
+ hangoutBounds: {widht: 10, height: 10, left:10, top: 10}
});
window.requestAnimationFrame(function(){
@@ -154,7 +158,6 @@ QUnit.asyncTest('connect() should return access code',
chrome.identity.getAuthToken.restore();
base.isAppsV2.restore();
- remoting.MessageWindow.showConfirmWindow.restore();
QUnit.start();
});
});
« no previous file with comments | « remoting/webapp/js_proto/chrome_proto.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698