remoting/webapp/crd/js/typecheck.js - Issue 888323002: Improve HRD first run experience

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/crd/js/typecheck.js

Issue 888323002: Improve HRD first run experience (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ready for Checkin Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/webapp/crd/js/typecheck.js

diff --git a/remoting/webapp/crd/js/typecheck.js b/remoting/webapp/crd/js/typecheck.js

index fa31f55a3cc8b66cf44c18d88777b49660e782d7..7365238a40ca9797a949c57befdd2fd2930cdbee 100644

--- a/remoting/webapp/crd/js/typecheck.js

+++ b/remoting/webapp/crd/js/typecheck.js

@@ -41,7 +41,10 @@ function getArrayAttr(dict, key, opt_default) {

function getBooleanAttr(dict, key, opt_default) {

var value = /** @type {boolean} */ (dict[key]);

- if (typeof value != 'boolean') {

+ if (value == 'true' || value == 'false') {

+ return (value == 'true');

+ }

+ if (typeof value !== 'boolean') {

if (opt_default === undefined) {

throw 'Invalid data type for ' + key +

' (expected: boolean, actual: ' + typeof value + ')';

« no previous file with comments | « remoting/webapp/crd/js/remoting.js ('k') | remoting/webapp/js_proto/chrome_proto.js » ('j') | no next file with comments »