Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 8883011: Implement ICs for constructor calls. (Closed)

Created:
9 years ago by Michael Starzinger
Modified:
8 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Implement ICs for constructor calls. This reuses the CallIC machinery for calling functions as constructors by flagging those CallICs with a bit in the ExtraICState. The CallIC in turn will dispatch to the function-specific construct stub. It also introduces new base class (i.e. CallBase) for all AST nodes having a call-like semantic (i.e. Call and CallNew). R=kmillikin@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -182 lines) Patch
M src/ast.h View 3 chunks +37 lines, -41 lines 0 comments Download
M src/ast.cc View 1 chunk +1 line, -11 lines 0 comments Download
M src/full-codegen.h View 2 chunks +10 lines, -4 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 5 chunks +52 lines, -26 lines 0 comments Download
M src/ia32/ic-ia32.cc View 12 chunks +43 lines, -25 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 8 chunks +37 lines, -20 lines 0 comments Download
M src/ic.h View 4 chunks +30 lines, -13 lines 0 comments Download
M src/ic.cc View 6 chunks +25 lines, -14 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/stub-cache.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/stub-cache.cc View 12 chunks +22 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
This only works on IA32 so far, but I wanted to get a first round ...
9 years ago (2011-12-08 10:22:18 UTC) #1
Kevin Millikin (Chromium)
My high level comment is that I'm skeptical that this is the right approach. You ...
9 years ago (2011-12-08 11:15:19 UTC) #2
Michael Starzinger
8 years, 11 months ago (2012-01-27 16:31:05 UTC) #3
For record: This CL was superseded by another one. We now use global property
cells instead of ICs to get type feedback for constructor calls.

https://chromiumcodereview.appspot.com/8932004/

Powered by Google App Engine
This is Rietveld 408576698