allow GMs to animate

allow GMs to animate

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/d9adfe6a223955bc69c8c7661ab8e0a078afbc32

[reed2, 2015-01-31 15:31:43]

reed@chromium.org changed reviewers:
+ bsalomon@google.com, reed@google.com

[reed2, 2015-01-31 15:31:43]

ptal

[reed2, 2015-01-31 15:31:47]

The CQ bit was checked by reed@chromium.org

[commit-bot: I haz the power, 2015-01-31 15:32:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/888283002/1

[commit-bot: I haz the power, 2015-01-31 15:32:28]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-01-31 21:32 UTC

[reed2, 2015-01-31 16:39:42]

The CQ bit was unchecked by reed@chromium.org

[reed2, 2015-01-31 16:40:01]

going to tweak it some more first...

[bsalomon, 2015-02-01 02:19:48]

On 2015/01/31 16:40:01, reed2 wrote:
> going to tweak it some more first...

seems ok but two Q's:

1) Should there be a now() query in GM's onDraw? Or does it always make sense
for GMs to update anim params in the pulse callback?

2) Is it possible to make Samples use the new mechanism and remove the current
Sample animation framework?

[reed2, 2015-02-01 03:02:44]

On 2015/02/01 02:19:48, bsalomon wrote:
> On 2015/01/31 16:40:01, reed2 wrote:
> > going to tweak it some more first...
> 
> seems ok but two Q's:
> 
> 1) Should there be a now() query in GM's onDraw? Or does it always make sense
> for GMs to update anim params in the pulse callback?

I'm thinking it will prove easier to organize things if we have an explicit
timer call (pulse). If that does not prove out, should be easy to switch over to
having the GM poll.
One advantage is that the explicit call informs the caller if the GM wants to be
drawn again (i.e. is "animating").

> 
> 2) Is it possible to make Samples use the new mechanism and remove the current
> Sample animation framework?

Sounds good, I will look to do that.

[bsalomon, 2015-02-01 03:43:05]

On 2015/02/01 03:02:44, reed2 wrote:
> On 2015/02/01 02:19:48, bsalomon wrote:
> > On 2015/01/31 16:40:01, reed2 wrote:
> > > going to tweak it some more first...
> > 
> > seems ok but two Q's:
> > 
> > 1) Should there be a now() query in GM's onDraw? Or does it always make
sense
> > for GMs to update anim params in the pulse callback?
> 
> I'm thinking it will prove easier to organize things if we have an explicit
> timer call (pulse). If that does not prove out, should be easy to switch over
to
> having the GM poll.
> One advantage is that the explicit call informs the caller if the GM wants to
be
> drawn again (i.e. is "animating").

Sounds reasonable to me. 

> 
> > 
> > 2) Is it possible to make Samples use the new mechanism and remove the
current
> > Sample animation framework?
> 
> Sounds good, I will look to do that.

[bsalomon, 2015-02-01 03:43:43]

https://codereview.chromium.org/888283002/diff/20001/gm/gm.h
File gm/gm.h (right):

https://codereview.chromium.org/888283002/diff/20001/gm/gm.h#newcode95
gm/gm.h:95: bool animatePulse(SkMSec);
document meaning of 0?

If GM wants to draw differently when not animating (not just draw the first
frame of the animation) what's the signal? animatePulse() is never called?

[reed2, 2015-02-01 04:25:12]

(0, 0) is passed when the clients wants the non-animating version.

[reed2, 2015-02-01 04:25:20]

The CQ bit was checked by reed@chromium.org

[commit-bot: I haz the power, 2015-02-01 04:25:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/888283002/40001

[commit-bot: I haz the power, 2015-02-01 04:25:50]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-02-01 10:25 UTC

[commit-bot: I haz the power, 2015-02-01 10:25:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-01 10:25:50]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[bsalomon, 2015-02-01 20:20:33]

lgtm

[reed1, 2015-02-02 03:00:25]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-02-02 03:00:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/888283002/40001

[commit-bot: I haz the power, 2015-02-02 03:01:09]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d9adfe6a223955bc69c8c7661ab8e0a078afbc32