Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 888203002: Fixing token repetition bug (Closed)

Created:
5 years, 10 months ago by Charlie
Modified:
5 years, 10 months ago
Reviewers:
rkc
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing token repetition bug BUG=451598 When we stop playing, we need to clear the token stored in the AudioManager. Otherwise the old token will start playing while the new one is being encoded, which confuses the decoder on the receiving device.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/copresence/mediums/audio/audio_manager_impl.cc View 2 chunks +2 lines, -1 line 1 comment Download

Messages

Total messages: 8 (3 generated)
Charlie
See the linked bug for details. When we stop playing, we need to clear the ...
5 years, 10 months ago (2015-01-31 01:46:27 UTC) #2
rkc
lgtm nice find!
5 years, 10 months ago (2015-01-31 01:48:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888203002/1
5 years, 10 months ago (2015-01-31 01:51:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_rel/builds/3615)
5 years, 10 months ago (2015-01-31 07:53:15 UTC) #7
Charlie
5 years, 10 months ago (2015-01-31 17:01:14 UTC) #8
On 2015/01/31 07:53:15, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   win8_chromium_gn_rel on tryserver.chromium.win
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_...)

This builder is broken. Landing under a different CL with my @chromium account:

https://codereview.chromium.org/875843003/

Powered by Google App Engine
This is Rietveld 408576698