Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 888173002: cros: Restrict gaiaURL to be http and https only. (Closed)

Created:
5 years, 10 months ago by xiyuan
Modified:
5 years, 10 months ago
Reviewers:
zel
CC:
chromium-reviews, arv+watch_chromium.org, Nikita (slow), Roger Tawa OOO till Jul 10th
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Restrict gaiaURL to be http and https only. BUG=453994 Committed: https://crrev.com/86076330c0bb161d7660555c4f514200ca897218 Cr-Commit-Position: refs/heads/master@{#314070}

Patch Set 1 #

Patch Set 2 : fix blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M chrome/browser/resources/gaia_auth/main.js View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/gaia_auth/util.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
xiyuan
Low hanging fruit. Will work on using postMessage for passing params in a separate CL.
5 years, 10 months ago (2015-01-31 00:26:19 UTC) #2
zel
lgtm
5 years, 10 months ago (2015-01-31 02:32:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888173002/20001
5 years, 10 months ago (2015-01-31 02:56:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_rel/builds/3586)
5 years, 10 months ago (2015-01-31 11:14:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888173002/20001
5 years, 10 months ago (2015-01-31 16:24:53 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-31 22:08:58 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-31 22:09:49 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86076330c0bb161d7660555c4f514200ca897218
Cr-Commit-Position: refs/heads/master@{#314070}

Powered by Google App Engine
This is Rietveld 408576698