Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: tools/gn/secondary/base/BUILD.gn

Issue 88813005: Support Mac frameworks in GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_binary_target_writer.cc ('k') | tools/gn/variables.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/secondary/base/BUILD.gn
diff --git a/tools/gn/secondary/base/BUILD.gn b/tools/gn/secondary/base/BUILD.gn
index d6dc507ba2af42c092d734cf7fc83b404a4dac1f..50f35593d5ee091ef0bd47c1013e6b958b773368 100644
--- a/tools/gn/secondary/base/BUILD.gn
+++ b/tools/gn/secondary/base/BUILD.gn
@@ -2,12 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-config("base_libs") {
- if (!is_win) {
- libs = [ "dl" ]
- }
-}
-
component("base") {
external = true
sources = [
@@ -696,9 +690,7 @@ component("base") {
"//third_party/modp_b64",
]
- # So we can append below without worrying about whether it has been
- # previously defined or not.
- all_dependent_configs = [ ":base_libs" ]
+ libs = []
if (!is_chromeos) {
sources -= [
@@ -750,6 +742,7 @@ component("base") {
} else if (!is_nacl) {
# Non-Windows.
deps += "//third_party/libevent"
+ libs += "dl"
}
# Mac.
@@ -760,11 +753,31 @@ component("base") {
"strings/sys_string_conversions_posix.cc",
]
deps += "//third_party/mach_override"
+ libs += [
+ "AppKit.framework",
+ "ApplicationServices.framework",
+ "Carbon.framework",
+ "CoreFoundation.framework",
+ "Foundation.framework",
+ "IOKit.framework",
+ "Security.framework",
+ ]
} else {
# Non-Mac.
sources -= "files/file_path_watcher_kqueue.cc"
}
+ # IOS.
+ if (is_ios) {
+ libs += [
+ "CoreFoundation.framework",
+ "CoreGraphics.framework",
+ "CoreText.framework",
+ "Foundation.framework",
+ "UIKit.framework",
+ ]
+ }
+
# Linux.
if (is_linux) {
# TODO(brettw) these will need to be parameterized at some point.
« no previous file with comments | « tools/gn/ninja_binary_target_writer.cc ('k') | tools/gn/variables.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698