Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 88813002: Disable building simulator for "x86_64" (Closed)

Created:
7 years ago by sdefresne
Modified:
7 years ago
Reviewers:
Mark Mentovai, Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Disable building simulator for "x86_64" The buildbot have an old SDK / Xcode installed that does not support building a simulator target for "x86_64". BUG=chromium:322075 R=thakis@chromium.org CC=justincohen@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1799

Patch Set 1 #

Patch Set 2 : Fix tests on bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M test/ios/app-bundle/test-archs.gyp View 1 3 chunks +9 lines, -0 lines 0 comments Download
M test/ios/gyptest-archs.py View 1 1 chunk +23 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sdefresne
7 years ago (2013-11-26 17:24:40 UTC) #1
Mark Mentovai
It seems useful to have the test available if the simulator can support it (if ...
7 years ago (2013-11-26 17:27:42 UTC) #2
sdefresne
On 2013/11/26 17:27:42, Mark Mentovai wrote: > It seems useful to have the test available ...
7 years ago (2013-11-26 17:53:13 UTC) #3
Nico
lgtm Sorry about the old xcode version on the bots :-(
7 years ago (2013-11-26 21:29:06 UTC) #4
sdefresne
On 2013/11/26 21:29:06, Nico wrote: > lgtm > > Sorry about the old xcode version ...
7 years ago (2013-11-26 22:51:15 UTC) #5
Mark Mentovai
I’ll give you access.
7 years ago (2013-11-26 22:52:23 UTC) #6
Mark Mentovai
Now you have access.
7 years ago (2013-11-26 22:52:53 UTC) #7
sdefresne
Committed patchset #2 manually as r1799 (presubmit successful).
7 years ago (2013-11-26 23:10:24 UTC) #8
sdefresne
7 years ago (2013-11-26 23:11:40 UTC) #9
Message was sent while issue was closed.
On 2013/11/26 23:10:24, sdefresne wrote:
> Committed patchset #2 manually as r1799 (presubmit successful).

Thank you (it took me a while to figure how to commit and which password
to use, I should read the documentation more carefully, everything was
written there).

Powered by Google App Engine
This is Rietveld 408576698