Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 888113002: Retry: fix the Python invocation for cros_chromite (Closed)

Created:
5 years, 10 months ago by dnj
Modified:
5 years, 10 months ago
Reviewers:
Peter Mayo, agable
CC:
chromium-reviews, cmp-cc_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Retry: fix the Python invocation for cros_chromite Partial reimplementation of reverted https://codereview.chromium.org/890803003/ This fixes the Python invocation part. The runhooks invocation (recursion) part that caused the other CL to be reverted will be addressed elsewhere. BUG=414436 TEST=local - Ran `gclient sync`, works. - Ran `gclient runhooks`, works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dnj
PTAL, shouldn't break anything this time :)
5 years, 10 months ago (2015-01-30 20:29:32 UTC) #2
Peter Mayo
LGTM - wish you had re-uploaded the original as the first patchset
5 years, 10 months ago (2015-01-30 20:43:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888113002/1
5 years, 10 months ago (2015-01-30 20:45:31 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 20:46:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293885

Powered by Google App Engine
This is Rietveld 408576698