Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 888083004: Revert "Files.app: Add UMA for HardUnplugged events." (Closed)

Created:
5 years, 10 months ago by hirono
Modified:
5 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, asvitkine+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Files.app: Add UMA for HardUnplugged events." We no longer need these UMA. This reverts commit 7f60d255a1c40caf8985552155a0ae46acd45299. BUG=433734 TEST=None Committed: https://crrev.com/7722ddf92cfbef7e1981107f798aa9a255d2fce5 Cr-Commit-Position: refs/heads/master@{#314968}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -20 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/device_event_router.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/device_event_router.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
hirono
PTAL, thanks!
5 years, 10 months ago (2015-02-04 08:19:20 UTC) #2
mtomasz
lgtm
5 years, 10 months ago (2015-02-04 08:49:53 UTC) #3
hirono
+asvitkine - PTAL histograms.xml? Thanks!
5 years, 10 months ago (2015-02-04 10:14:00 UTC) #7
Alexei Svitkine (slow)
https://codereview.chromium.org/888083004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/888083004/diff/1/tools/metrics/histograms/histograms.xml#oldcode9469 tools/metrics/histograms/histograms.xml:9469: -<histogram name="FileBrowser.HardUnpluggedAroundSuspend.TimeSinceResume" Mark these entries as <obsolete> instead of ...
5 years, 10 months ago (2015-02-04 14:30:50 UTC) #9
hirono
Thanks! https://codereview.chromium.org/888083004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/888083004/diff/1/tools/metrics/histograms/histograms.xml#oldcode9469 tools/metrics/histograms/histograms.xml:9469: -<histogram name="FileBrowser.HardUnpluggedAroundSuspend.TimeSinceResume" On 2015/02/04 14:30:50, asvitkine (slow this ...
5 years, 10 months ago (2015-02-05 06:27:24 UTC) #11
Alexei Svitkine (slow)
lgtm
5 years, 10 months ago (2015-02-05 17:13:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888083004/20001
5 years, 10 months ago (2015-02-06 02:03:40 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-06 03:46:50 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 03:48:35 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7722ddf92cfbef7e1981107f798aa9a255d2fce5
Cr-Commit-Position: refs/heads/master@{#314968}

Powered by Google App Engine
This is Rietveld 408576698