Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 888043003: [Extensions Toolbar Views] Add a ToolbarActionView unittest (Closed)

Created:
5 years, 10 months ago by Devlin
Modified:
5 years, 10 months ago
Reviewers:
Finnur, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Toolbar Views] Add a ToolbarActionView unittest Add unittesting for ToolbarActionView to, at minimum, test the basic UI. Also remove the dependency of ToolbarActionView on Browser, and create a TestToolbarActionViewController. BUG=453841 TBR=sky@chromium.org (gn file change) Committed: https://crrev.com/bb461c8f803f441364fdbb9f5124045771daa31a Cr-Commit-Position: refs/heads/master@{#315130}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+497 lines, -85 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/component_toolbar_actions_browsertest.cc View 4 chunks +9 lines, -67 lines 0 comments Download
A chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h View 1 chunk +75 lines, -0 lines 0 comments Download
A chrome/browser/ui/toolbar/test_toolbar_action_view_controller.cc View 1 chunk +129 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/chevron_menu_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view.h View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view.cc View 5 chunks +6 lines, -11 lines 0 comments Download
A chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc View 1 chunk +267 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Devlin
5 years, 10 months ago (2015-01-31 00:35:13 UTC) #2
Finnur
LGTM
5 years, 10 months ago (2015-02-02 12:08:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888043003/40001
5 years, 10 months ago (2015-02-06 23:00:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/41115)
5 years, 10 months ago (2015-02-06 23:06:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888043003/40001
5 years, 10 months ago (2015-02-06 23:15:35 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-06 23:19:58 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 23:20:36 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bb461c8f803f441364fdbb9f5124045771daa31a
Cr-Commit-Position: refs/heads/master@{#315130}

Powered by Google App Engine
This is Rietveld 408576698